Safe yaml v3 #723
Merged
Safe yaml v3 #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbennett
force-pushed
the
safe-yaml-v3
branch
from
4c3a395
to
72f44bf
Compare
switching to safe loading changes the behaviour of the default regex parser when you give it a config that contains (unsupported) recursive environment variables. rather than update the tests to assert a different broken behaviour, we now raise a configuration error. this will alert the user that their config file will likely not be parsed correctly, or they're missing the optional library.
also change description from "recursive" to "nested"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent to #722, for v3 branch
--
Updates the logic parsing environment variables in configuration files. Now uses the safe version of pyyaml's parser rather than the unsafe version.
Behaviour is unchanged except for the unsupported case of using nested environment variables without the optional
regexpackage. Previously, depending on the structure of the string, a nested environment variable would sometimes be parsed correctly and sometimes incorrectly. Now, if your config file contains a nested environment variable and you do not have the optionalregexpackage installed, aConfigurationErrorwill be raised.