Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci #767

Merged
merged 26 commits into from
Feb 9, 2023
Merged

Fix ci #767

merged 26 commits into from
Feb 9, 2023

Conversation

mattbennett
Copy link
Member

@mattbennett mattbennett commented Feb 8, 2023

Various changes to get CI passing with updated dependencies and infra:

  1. Kombu 5.2.2 fixed a bug in how retries are counted celery/kombu@5bed2a8, so we account for that in test/amqp/test_publish.py
  2. Eventlet 0.33.3 is now required on Python 3.10, to avoid having to pin dnspython down instead
  3. No longer running tests on Python 3.7 because they're not supported on ubuntu-latest actions image
  4. isort, moto and pyjwt (dev packages) had to be upgraded to avoid dependency conflicts
  5. importlib-metadata needed pinning below 5.0 on py3.7 due to Celery Import Error celery/celery#7783
  6. docs build needed to run on older ubuntu-20.04 actions image due to lack of enchant library, and to pin jinja to a version compatible with the old version of sphinx we use.

not clear how this ever passed. it's unhelpfully tied to the kombu
implementation which probably means it's a bad test, but just fixing
it up for now
to a releaase that is still compatible with our old version of sphinx.
it's not worth trying to upgrade sphinx because the new docs use mkdocs
importlib-metadata is not on later versions of python, so we can use
a conditional pin. see # celery/celery#7783
also choose a version that works on all currently supported pythons
@mattbennett mattbennett merged commit 03ce391 into nameko:v3.0.0-rc Feb 9, 2023
@mattbennett mattbennett deleted the fix-ci branch February 9, 2023 20:52
mattbennett added a commit to mattbennett/nameko that referenced this pull request Feb 9, 2023
* fix flakiness in publish retry tests

not clear how this ever passed. it's unhelpfully tied to the kombu
implementation which probably means it's a bad test, but just fixing
it up for now

* upgrade isort

* rename whitelist -> allowlist

* upgrade moto and pyjwt

* bump requests to resolve conflict with boto

* pyjwt requires you to specify algorithm now

* upgrade urllib to resolve dependency tree

* expected retries isn't flakey; depends on version of kombu

* update import following deprecation, removes warning

* pytest arg --strict renamed to --strict-markers

* import sort

* no cover pragmas for kombu version conditionals

* pyjwt and moto require older versions on py2

* run docs on ubuntu 20.04; drop 3.6 from matrix

* put 3.6 back and try all on 20.04

* drop 3.6 again

* sort 5.12.0 not available on py3.7

* pin down jinja

to a releaase that is still compatible with our old version of sphinx.
it's not worth trying to upgrade sphinx because the new docs use mkdocs

* importlib-metadata 5.0 is not compatible with latest kombu on py3.7

importlib-metadata is not on later versions of python, so we can use
a conditional pin. see # celery/celery#7783

* upgrade pinned version of eventlet

fixes https://stackoverflow.com/questions/75137717/eventlet-dns-python-attribute-error-module-dns-rdtypes-has-no-attribute-any

* whoops; fix syntax in setup.py

* oldest eventlet on py3.10 needs updating too

* match "pinned" requests to the one in dev reqs

also choose a version that works on all currently supported pythons

* refactor conditional to avoid another pragma

* copy/paste snafu

* try running tests on ubuntu latest
# Conflicts:
#	docs/examples/test/test_examples.py
#	nameko/cli/__init__.py
#	nameko/cli/utils/__init__.py
#	nameko/rpc.py
#	nameko/testing/pytest.py
#	test/amqp/test_publish.py
@mattbennett mattbennett mentioned this pull request Feb 10, 2023
mattbennett added a commit that referenced this pull request Feb 13, 2023
* backport changes from #767 to master branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant