Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add possobility to login with credentials #1

Merged
merged 4 commits into from
Jun 12, 2014

Conversation

allomov
Copy link
Contributor

@allomov allomov commented May 18, 2014

I've write some code quickly to solve this problem. Currently I use monkey patch with this gem to add this functionality.

@allomov
Copy link
Contributor Author

allomov commented May 29, 2014

/cc @namelessjon

@namelessjon
Copy link
Owner

Oh, damn, I meant to get back to you about this sooner.

I don't get how this code is actually working? It doesn't look much like the monkey patch you link to!

@namelessjon
Copy link
Owner

Oh wait, you added another patch, I missed that

# Get authentication token using user email and password,
# set up this token for making requests (see #setup method)
def self.login(email, password)
response = HTTParty.post('http://todoist.com/API/login', {body: {email: email, password: password}})
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be to the https url.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, thanks, but it works as http also :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I think that's a problem with the todoist service. But I don't see the point in unnecessarily exposing user credentials, even if the service will let you 😉

@namelessjon
Copy link
Owner

Also, I no longer use the todoist service, so I don't have any possibility to test these changes myself. Also, most importantly, thanks for your interest in the gem. 😄

@allomov
Copy link
Contributor Author

allomov commented May 30, 2014

@namelessjon what do you use now by the way?
I tested this code for my ilpomodoro branch.

Your gem was very helpful for it, thank you.

@namelessjon
Copy link
Owner

I use orgmode for emacs, and sync changes about with git. It works for what I need, TODOs wise, and means its integrated with the rest of my notes and journal.

namelessjon added a commit that referenced this pull request Jun 12, 2014
add possobility to login with credentials
@namelessjon namelessjon merged commit 65f0494 into namelessjon:master Jun 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants