Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing multiple "includes" #72

Closed
blimmer opened this issue May 16, 2018 · 1 comment
Closed

Allow passing multiple "includes" #72

blimmer opened this issue May 16, 2018 · 1 comment

Comments

@blimmer
Copy link
Contributor

blimmer commented May 16, 2018

As implemented today, you can't pass multiple includes via a -i parameter. Each invocation of -i overwrites the last.

Here's the code that does that:

-i) shift
EXTRA_INCLUDES="-I$1"
shift
;;

So, invocations like this don't work

docker run ... namely/protoc-all:1.11 -i protorepo -i something_else

It would be nice if each -i added onto the EXTRA_INCLUDES.

blimmer added a commit to blimmer/docker-protoc that referenced this issue May 16, 2018
@blimmer
Copy link
Contributor Author

blimmer commented May 16, 2018

I pushed this change to dockerhub if you'd like to test it out. the tag is:

blimmer/protoc-all:1.11-extra-includes

mdkess pushed a commit that referenced this issue May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant