refactor(use-interval): not call immediate when delay is falthy

namepain · Dec 28, 2019 · c3a98ff · c3a98ff
1 parent 1269a82
commit c3a98ff
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@namepain/hooks",
-  "version": "0.0.1-development",
+  "version": "0.0.3",
   "description": "",
   "keywords": [
     "react hooks"

diff --git a/src/useInterval.ts b/src/useInterval.ts
@@ -1,4 +1,4 @@
-import { useRef, useEffect } from 'react'
+import { useRef, useEffect, useCallback } from 'react'
 
 interface SaveRef {
   fn: () => any
@@ -19,7 +19,7 @@ export default function useInterval(
 
   useEffect(() => {
     saved.current.fn = callback
-    if (immediate) {
+    if (immediate && delay) {
       saved.current.fn()
     }
   }, [callback, immediate])
@@ -40,7 +40,7 @@ export default function useInterval(
     }
   }, [delay])
   return {
-    stop: () => clearTimeout(saved.current.timer),
-    resume: () => saved.current.loop && saved.current.loop()
+    stop: useCallback(() => clearTimeout(saved.current.timer), []),
+    resume: useCallback(() => saved.current.loop && saved.current.loop(), [])
   }
 }