Control triggers at runtime #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
clementguidi
force-pushed
the
runtime-triggers
branch
from
25e7aa9
to
8bc9d89
Compare
namhyung
reviewed
May 31, 2023
When do you plan to release v0.14? |
No specific date, but I hope I can do it this weekend. :) |
clementguidi
force-pushed
the
runtime-triggers
branch
from
8bc9d89
to
208b46e
Compare
namhyung
reviewed
Jun 6, 2023
clementguidi
force-pushed
the
runtime-triggers
branch
from
208b46e
to
dc36d43
Compare
clementguidi
force-pushed
the
runtime-triggers
branch
from
dc36d43
to
8055e9a
Compare
|
Note: I renamed a field in the action structure, because I can never figure out intuitively whether struct trigger_action_parser {
const char *name;
int (*parse)(char *action, struct uftrace_trigger *tr,
struct uftrace_filter_setting *setting);
- unsigned long flags;
+ enum trigger_flag compat_flags; /* flags the action is restricted to */
}; |
|
I'm ok with |
namhyung
reviewed
Jun 13, 2023
clementguidi
force-pushed
the
runtime-triggers
branch
from
8055e9a
to
8345288
Compare
namhyung
approved these changes
Jun 13, 2023
clementguidi
force-pushed
the
runtime-triggers
branch
from
8345288
to
99b84ab
Compare
Yes I missed that. Thank you again Namhyung! |
|
Can you please rebase to the current master? |
The --trigger option was documented but not implemented. Signed-off-by: Clément Guidi <cguidi@ciena.com>
Make it clear that the action flags are the flags the action is compatible with. Signed-off-by: Clément Guidi <cguidi@ciena.com>
Register triggers at runtime using the agent. The '--trigger' option can be used from the client, and is forwarded to the target. Signed-off-by: Clément Guidi <cguidi@ciena.com>
Handle 'clear' action separately so it doesn't interfere with other actions' flags. Signed-off-by: Clément Guidi <cguidi@ciena.com>
Disable and delete trigger actions at runtime from the client. Use the 'clear' action to delete the given actions, or all actions associated to a given symbol. $ uftrace -p PID -T func@clear # clear all 'func' triggers $ uftrace -p PID -T func@clear=act1+act2 # clear act1 and act2 on 'func' The following trigger actions are supported: arg, retval, filter, depth, time, size, hide, trace, finish, read, color, backtrace, recover. Signed-off-by: Clément Guidi <cguidi@ciena.com>
Add and remove various trigger actions at runtime. Signed-off-by: Clément Guidi <cguidi@ciena.com>
clementguidi
force-pushed
the
runtime-triggers
branch
from
99b84ab
to
e5d11a2
Compare
|
Done. I'm updating #1647 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits give the user full control over triggers at runtime. It applies to
all actions.
It allows the user to control the target process from the client as follows:
$ uftrace -p PID -T func@act1[,act2]$ uftrace -p PID -T func@act1[,act2],clear$ uftrace -p PID -T func@clearTrigger parameters can be omitted when deleting actions. For example:
$ uftrace -p PID -T func@depth,clear$ uftrace -p PID -T func@time,read,clearWe also fix the
--triggeroption which was actually not implemented.Based on #1645.