cmd/recv.c: Migrate from deprecated gethostbyname() to getaddrinfo() #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardkaindl
force-pushed
the
migrate-from-deprecated-gethostbyname-to-getaddrinfo
branch
3 times, most recently
from
0967340
to
d3f0484
Compare
namhyung
reviewed
Mar 28, 2023
The Fedora review-tool runs rpmlint on the binary packages and warned that the uftrace tool was using gethostbyname. Switching to getaddrinfo helps to get accepted, also for later uftrace distro packaging reviews: POSIX.1-2008 removes the specifications of gethostbyname(), gethostbyaddr(), and h_errno, recommending the use of getaddrinfo(3) and getnameinfo(3) instead: They return a list of addrs or hostnames, are thread-safe and optionally allow us to also use IPv6. This 1st step continues with IPv4 and only still tries to connect to the primary, 1st address (for a small commit). Signed-off-by: Bernhard Kaindl <contact@bernhard.kaindl.dev>
bernhardkaindl
force-pushed
the
migrate-from-deprecated-gethostbyname-to-getaddrinfo
branch
from
d3f0484
to
ff1fc1c
Compare
bernhardkaindl
changed the title
|
Fixed to add parentheses for memset(&hints, 0, sizeof(hints)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit message:
cmd/recv.c: Migrate from deprecated gethostbyname() to getaddrinfo()
The Fedora review-tool runs rpmlint on the binary packages and warned
that the uftrace tool was using gethostbyname. Switching to getaddrinfo
helps to get accepted, also for later uftrace distro packaging reviews:
POSIX.1-2008 removes the specifications of gethostbyname(), gethostbyaddr(),
and h_errno, recommending the use of getaddrinfo(3) and getnameinfo(3) instead:
They return a list of addrs or hostnames, are thread-safe and optionally
allow us to also use IPv6. This 1st step continues with IPv4 and only
still tries to connect to the primary, 1st address (for a small commit).