Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic: Print dynamic patch stats for skipped #1675

Merged
merged 1 commit into from Apr 29, 2023

Conversation

honggyukim
Copy link
Collaborator

Currently, dynamic patch stat info is not printed when there is skipped functions without failed one.

This patch also checks whether there is a skipped function to print dynamic patched function stats.

  $ uftrace record --debug-domain dynamic:1 -P. -Z 10 a.out
  dynamic: dynamic patch type: a.out: 0 (none)
  dynamic: patched all (4) functions in 'a.out'

Before:

  $ uftrace record --debug-domain dynamic:1 -P. -Z 30 a.out
  dynamic: dynamic patch type: a.out: 0 (none)

After:

  $ uftrace record --debug-domain dynamic:1 -P. -Z 30 a.out
  dynamic: dynamic patch type: a.out: 0 (none)
  dynamic: dynamic patch stats for 'a.out'
  dynamic:    total:        4
  dynamic:  patched:        2 (50.00%)
  dynamic:   failed:        0 ( 0.00%)
  dynamic:  skipped:        2 (50.00%)
  dynamic: no match:        0

Currently, dynamic patch stat info is not printed when there is skipped
functions without failed one.

This patch also checks whether there is a skipped function to print
dynamic patched function stats.

  $ uftrace record --debug-domain dynamic:1 -P. -Z 10 a.out
  dynamic: dynamic patch type: a.out: 0 (none)
  dynamic: patched all (4) functions in 'a.out'

Before:
  $ uftrace record --debug-domain dynamic:1 -P. -Z 30 a.out
  dynamic: dynamic patch type: a.out: 0 (none)

After:
  $ uftrace record --debug-domain dynamic:1 -P. -Z 30 a.out
  dynamic: dynamic patch type: a.out: 0 (none)
  dynamic: dynamic patch stats for 'a.out'
  dynamic:    total:        4
  dynamic:  patched:        2 (50.00%)
  dynamic:   failed:        0 ( 0.00%)
  dynamic:  skipped:        2 (50.00%)
  dynamic: no match:        0

Signed-off-by: Honggyu Kim <honggyu.kp@gmail.com>
Copy link
Owner

@namhyung namhyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namhyung namhyung merged commit 6c3fb74 into namhyung:master Apr 29, 2023
2 checks passed
@honggyukim honggyukim deleted the check/print-patch-stats branch April 30, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants