Refactor the kernel depth option and documentation #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, @ChoKyuWon. Thank you for the first patch on OSSCA 2023!
|
namhyung
reviewed
Jul 16, 2023
uftrace.c
Outdated
| @@ -655,14 +655,15 @@ static int parse_option(struct uftrace_opts *opts, int key, char *arg) | |||
|
|
|||
| case 'k': | |||
| opts->kernel = true; | |||
| opts->kernel_depth = 1; | |||
| break; | |||
|
|
|||
| case 'K': | |||
| opts->kernel = true; | |||
| opts->kernel_depth = strtol(arg, NULL, 0); | |||
| if (opts->kernel_depth < 1 || opts->kernel_depth > 50) { | |||
| pr_use("invalid kernel depth: %s (ignoring...)\n", arg); | |||
There was a problem hiding this comment.
You can say "set to 1" instead of "(ignoring...)".
ChoKyuWon
force-pushed
the
master
branch
3 times, most recently
from
98687fd
to
e9c3205
Compare
initialize the opts->kernel_depth to 1 in '-k' and remove the ternary operator in setup_writers. Signed-off-by: ChoKyuWon <kyuwoncho18@gmail.com>
Signed-off-by: ChoKyuWon <kyuwoncho18@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To process the
-koption, thekernel_depthin opt field is not set and is set to 1 when used (setup_writers).This PR initializes the
opts->kernel_depthto 1 at the case-kand-Kif the input value is invalid.This refactoring clarifies the code semantic when the user only uses the
-k, and invalid-K.