tests: Changing test case statistics conditions. #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, @coyotek Thank you for your contribution :D According to https://github.com/namhyung/uftrace/pull/1771/checks?check_run_id=15268583617, You can check git config and edit user.name git config --list # check git config
git config --global user.name <name> # edit user.nameamend and push git commit --amend -s
git push --force |
namhyung
reviewed
Jul 26, 2023
There was a problem hiding this comment.
Please remove description of the issue (1770) as it's outdated. You'd better describe the change in the commit message directly something like:
tests: Change test result statistics condition
As it comes with more combinations of compiler and flags,
it's better to update the condition to print the test stats.
Specifically we want to print it when there are more than
100 test runs or more than 10 kind of tests were run.
Fixed: #1770
Signed-off-by: ...
honggyukim
reviewed
Jul 26, 2023
As it comes with more combinations of compiler and flags, it's better to update the condition to print the test stats. Specifically we want to print it when there are more than 300 test runs or more than 10 kind of tests were run. Fixed: namhyung#1770 Signed-off-by: Jungmin Kim <jungmin82@gmail.com>
coyotek
force-pushed
the
print_test_report
branch
from
0d1816f
to
60dfac1
Compare
honggyukim
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests: Change test result statistics condition
As it comes with more combinations of compiler and flags,
it's better to update the condition to print the test stats.
Specifically we want to print it when there are more than
300 test runs or more than 10 kind of tests were run.
Fixed: #1770
Signed-off-by: Jungmin Kim jungmin82@gmail.com