filter: Remove obsolete function add_trigger #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sypark9646
force-pushed
the
refactor/remove-add-trigger-function
branch
2 times, most recently
from
7d25b04
to
201d429
Compare
sypark9646
changed the title
sypark9646
force-pushed
the
refactor/remove-add-trigger-function
branch
from
201d429
to
3b985f4
Compare
honggyukim
reviewed
Aug 26, 2023
sypark9646
changed the title
|
@honggyukim Thank you! I'll fix the branch naming and PR again |
|
No, please reopen this PR and force push to the same branch to update this patch. |
|
I will reopen this PR. |
|
Hmm.. the branch is already deleted. |
|
Sorry, when I renamed the branch in the forked repository, the old branch disappeared - I've restored it now! |
The function add_trigger has been replaced with update_trigger, rendering it unnecessary. This commit removes the now-unused add_trigger function. Signed-off-by: Soyeon Park <sypark9646@gmail.com>
sypark9646
force-pushed
the
refactor/remove-add-trigger-function
branch
from
3b985f4
to
58e37d6
Compare
honggyukim
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function add_trigger has been replaced with update_trigger,
rendering it unnecessary. This commit removes the now-unused
add_trigger function.
related: eeb5d74
Signed-off-by: Soyeon Park sypark9646@gmail.com