mcount: Fix a compiler warning on PAGE_SIZE #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The musl libc defines PAGE_SIZE macro and shows warning like this:
/usr/src/uftrace/libmcount/dynamic.c:43: warning: "PAGE_SIZE" redefined
43 | #define PAGE_SIZE 4096
|
In file included from /usr/include/fortify/stdlib.h:30,
from /usr/src/uftrace/libmcount/dynamic.h:5,
from /usr/src/uftrace/libmcount/dynamic.c:24:
/usr/include/limits.h:97: note: this is the location of the previous definition
97 | #define PAGE_SIZE PAGESIZE
Signed-off-by: Paran Lee <p4ranlee@gmail.com>
paranlee
commented
Feb 4, 2024
| @@ -40,7 +40,6 @@ static struct mcount_dynamic_stats { | |||
| int unpatch; | |||
| } stats; | |||
|
|
|||
| #define PAGE_SIZE 4096 | |||
There was a problem hiding this comment.
libmcount/dynamic.h have PAGE_SIZE macro.
|
I feel like we should not use hard-coded PAGE_SIZE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The musl libc defines PAGE_SIZE macro and shows warning like this:
/usr/src/uftrace/libmcount/dynamic.c:43: warning: "PAGE_SIZE" redefined
43 | #define PAGE_SIZE 4096
|
In file included from /usr/include/fortify/stdlib.h:30,
from /usr/src/uftrace/libmcount/dynamic.h:5,
from /usr/src/uftrace/libmcount/dynamic.c:24:
/usr/include/limits.h:97: note: this is the location of the previous definition
97 | #define PAGE_SIZE PAGESIZE