Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix ci warning on GitHub Acitons #1885

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Feb 8, 2024

by changing actions/checkout from v3 to v4
actions/setup-python from v4 to v5
warning on GitHub Acitions

before:
image

after:
image

@yihong0618 yihong0618 force-pushed the fix_actions_warning branch 2 times, most recently from 5d83556 to 1a3813b Compare February 8, 2024 15:22
Copy link
Owner

@namhyung namhyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the commit message like this?

misc: Fix warnings on GitHub Actions

There are warnings on the GitHub Actions due to Node.js 16
deprecation. Update the version of the actions to get rid of
the warnings.

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20

Signed-off-by: ...

There are warnings on the GitHub Actions due to Node.js 16
deprecation. Update the version of the actions to get rid of
the warnings.

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20

Signed-off-by: Yi Hong <zouzou0208@gmail.com>
@yihong0618
Copy link
Contributor Author

There are warnings on the GitHub Actions due to Node.js 16
deprecation. Update the version of the actions to get rid of
the warnings.

Done

Copy link
Owner

@namhyung namhyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namhyung namhyung merged commit 94c2655 into namhyung:master Feb 9, 2024
3 checks passed
@yihong0618 yihong0618 deleted the fix_actions_warning branch February 12, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants