build: Fix compiler warnings #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MichelleJin12 Thank you, this issue could be reproduced in RHEL7 |
paranlee
reviewed
Mar 17, 2024
| @@ -14,6 +14,8 @@ struct script_info; | |||
|
|
|||
| #if defined(HAVE_LIBPYTHON2) || defined(HAVE_LIBPYTHON3) | |||
|
|
|||
| #undef _XOPEN_SOURCE | |||
| #undef _POSIX_C_SOURCE | |||
There was a problem hiding this comment.
Right! This header file activated when configure script have_libpython* condition from existing user's libpython.
Then, check-deps/Makefile -> HAVE_LIBPYTHON* macro would be enabled.
namhyung
reviewed
Mar 17, 2024
Fix compiler warnings when using python2.7
_POSIX_C_SOURCE and _XOPEN_SOURCE macros are defined in python header.
/usr/include/python2.7/pyconfig-64.h:1191:0: error: "_POSIX_C_SOURCE" redefined [-Werror]
#define _POSIX_C_SOURCE 200112L
^
In file included from /usr/include/inttypes.h:25:0,
from /home/uftrace/libmcount/mcount.h:12,
from /home/uftrace/utils/script.h:11,
from /home/uftrace/utils/script.c:13:
/usr/include/features.h:168:0: note: this is the location of the previous definition
# define _POSIX_C_SOURCE 200809L
^
In file included from /usr/include/python2.7/pyconfig.h:6:0,
from /usr/include/python2.7/Python.h:8,
from /home/uftrace/utils/script-python.h:18,
from /home/uftrace/utils/script.h:13,
from /home/uftrace/utils/script.c:13:
/usr/include/python2.7/pyconfig-64.h:1213:0: error: "_XOPEN_SOURCE" redefined [-Werror]
#define _XOPEN_SOURCE 600
^
In file included from /usr/include/inttypes.h:25:0,
from /home/uftrace/libmcount/mcount.h:12,
from /home/uftrace/utils/script.h:11,
from /home/uftrace/utils/script.c:13:
/usr/include/features.h:170:0: note: this is the location of the previous definition
# define _XOPEN_SOURCE 700
^
Fixed: namhyung#1276
Signed-off-by: Michelle Jin <shjy180909@gmail.com>
MichelleJin12
force-pushed
the
python2.7_build_error
branch
from
92eb931
to
403a7d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compiler warnings when using python2.7
Fixed: #1276
Signed-off-by: Michelle Jin shjy180909@gmail.com