Resolve some issues with (DTLS) session management and add some tests. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
Before this commit, client-side sessions were kept in a Vec inside of the CoapContext for the entire lifetime of the context instead of freeing them as soon as they were dropped. This commit fixes the issue by fixing the Drop implementation of CoapClientSessionInner, which caused a SIGABRT if it was called outside of the CoapContext drop handler. Additionally, client-side sessions are no longer stored in the CoapContext, as they were not used there except for in the Drop implementation, which is no longer necessary due to the aforementioned fix.
falko17
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a number of smaller issues with DTLS support and adds a basic DTLS test, refactoring out common parts between the UDP and DTLS test cases.
The following issues were resolved:
UseCurrentresponse for CoapServerCryptoProviders wasn't handled properly: The handler did not consider the correct key.There is still one more issue that remains to be resolved: Currently, client-side sessions are kept in memory until the context is dropped, and not doing so causes some more crashes because the event handler is then called on a session that is in the process of being dropped. I'll look into that problem in the next few days.Update: Is now fixed by temporarily disabling the event handler in the client side session drop implementation.