webui: click outside of clan member modal to close #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antibert Hello, friend!!!! it's so good to see you. There is one problem with the floating-vue library: Also, I plan to update webUi dependencies here #245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix to #36
In the current situation the autoHide prop is overridden for the clan member detail modal and set to
false. This makes it so that closing the modal by clicking outside it is disabled. Removing this prop reverts back to the default behaviour where the modal can be closed by clicking outside of it.Also changed the unit test for
use-modal-countsince it was failing. Seems like a guard statement was added to the modal counter that wasn't reflected in the unit test yet.