[bug fix] Empty branch merge in change-log #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MatsMoll thanks so much for the contribution! This looks great — just pulled the branch down and tested it a bit. Seems to work well! |
namolnad
approved these changes
Jan 3, 2020
|
Sorry, approved a little too quickly. Can you add a test case in |
|
Ups, but yes! Will add a test for it |
|
I did not quite understand the testing framework. But it passes and the output seems to be correct |
|
yeah, looks as though you figured it out — thanks for adding the test and again for the PR! (Not sure why CI isn't running tests/linting, but I ran them locally and all looks well) |
|
btw if you want to check out the testing framework it's @pointfreeco's snapshot tool: https://github.com/pointfreeco/swift-snapshot-testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A branch merger was recored to it's own commit, but with noe message, author or link. (This was a problem as github's API did not accept it when this was a tags change-log body.)
This sesames to be fixed by removing the --graph flag when fetching the git log.
E.g: