Be less strict on phpseclib #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #65 to address the CS issue. |
|
See #66 to address the travis issue. |
|
@GrahamCampbell I had to force pushed master as the tag 6.0.4 had one issue, could you please rebase your PR with master? thanks |
|
@GrahamCampbell I'm worried on being less strict on phpseclib because I remember we had an issue with that lib updating to a new minor version preventing jose to work properly |
0.x minor releases are not BC. 1.x are as per semver. I can assure your're not breaking stuff on 1.x. :) |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, any chance we could upgrade to
~2.0in the 7.x series?