Design changes prog4 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve unnecessary conditional checks
…ents based on db type
…generation based on DB type
api/v1alpha1/ndb_api_helpers.go
Outdated
Comment on lines
132
to
140
| // Setting action arguments based on database type | ||
| dbTypeActionArgs := GetActionArgumentsByDatabaseType(dbSpec.Instance.Type) | ||
| if dbTypeActionArgs != nil { | ||
| req.ActionArguments = append(req.ActionArguments, dbTypeActionArgs.GetActionArguments(dbSpec)...) | ||
| } else { | ||
| var errStatement string | ||
| err = errors.New("Invalid Database Type") | ||
| errStatement = "Invalid Database Type: supported values: mysql, postgres, mongodb" | ||
| log.Error(err, errStatement) |
There was a problem hiding this comment.
Would it make sense to return th error from the function GetActionArgumentsByDatabaseType() instead?
Thinking about extensibility with the current code - if we add another DB engine / type in the future then we might have to change code at two places: GetActionArgumentsByDatabaseType and this code block (error statement). Returning an error from the default case and checking the return values of the GetActionArgumentsByDatabaseType() call might be a cleaner approach.
Something like:
dbTypeActionArgs, err := GetActionArgumentsByDatabaseType(dbSpec.Instance.Type)
if err != nil {
log.Error(err, "Error occurred while getting dbTypeActionArgs", "database type", dbSpec.Instance.Type)
return
}
What do you think?
There was a problem hiding this comment.
Hi Manav,
Updated the same PR with your suggested changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To modularise the GenerateProvisioningRequest API by incorporating DRY principles and removing unwieldy conditional checks.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
How Has This Been Tested?:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and test output
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: