Add testID prop to MotiPressable for improved testability
#328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@nandorojo bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces the addition of the native
testIDprop to theMotiPressablecomponent. The purpose of this change is to facilitate better testing practices by allowing developers to assign a test ID toMotiPressableelements.Changes
testIDprop has been added to theMotiPressablePropstype definition.testIDprop is now deconstructed from the props inMotiPressable.tsxand passed down to the underlyingPressablecomponent. This allows for thetestIDto be utilized in testing frameworks like Jest for selecting elements.Benefits
With the
testIDprop, developers can write more robust tests for components that utilizeMotiPressable. This small but significant enhancement improves the testability of components, making it easier to maintain high-quality code standards.