-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up problems #1
Comments
README says the following:
but… I don't see a “Download JSON” link or button to click |
Hey @drew-yieldbot, glad to help! Would you mind opening up another issue for this? Also I'm guessing you're working off the |
Hi, I've been able to set up an order and create line items at this point, but I get caught up with the Key Value pair associations on the line item. I'm having a hard time figuring out how to get these in there. Below is the code that gives me an error in the dfp.js file. I'm assuming it's because it doesnt' know how to lookup these values. Can you shed some light on what steps I might take to resolve this issue? In the scripts/create-line-items.js in the getCombinations() method. The other issue I see is that you have set it up to have all of your creatives separated out by ad unit. We are trying to add all creative sizes to each line item in order to reduce the amount of orders and line items we create. For example, I can create 2,000 total line items to get bids from 0.01 to 20.00 and have all creatives available to run there. Has anyone done this modification to this library and have any advice? Thank you! |
Are you using the prebid branch https://github.com/spanishdict/example-dfp-line-item-generator/tree/prebid ? This branch is setup to create 2000 line items as you mention. What error do you see? It should work as is, except there is one change you may need to use the prebid branch. In node_module dependencies node-google-dfp-wrapper, i commented out |
I can't believe I missed this branch. Looks like that's exactly what I'm looking for. I heavily modified the master branch and one of the things I changed was the same thing you mentioned. I also pass through a placement ID instead so I never have to update the line items with new ad units. |
Thanks for the advice @nanek, it's working fine but I did come across an issue when associating creatives. The script failed for me and I have 100 left on a order. How do you suggest handling the error below? --partner PREBID |
I've encountered this issue as well. It's been awhile, however I believe I just ran it again after waiting for a period of time. I believe we are hitting a rate limit from google's API. I recall waiting between creating orders to avoid hitting this half way through. |
Closing this general issue. Please open a new issue if needed. Thanks! |
Please let us know here if you're having troubles getting started!
The text was updated successfully, but these errors were encountered: