Jits msg in game setup #25
Conversation
|
Code needs some touches, will check this next week |
| @@ -1,4 +1,4 @@ | |||
|
|
|||
| var linkidShort = Date.now().toString().substring(10); | |||
There was a problem hiding this comment.
Move inside the g_NetworkCommands["/jitsi"]
There was a problem hiding this comment.
its global. because the link should stay the same during the config and the game. its generated from milisecond from now.
| @@ -268,7 +268,8 @@ g_NetworkCommandsDescriptions = Object.assign(g_NetworkCommandsDescriptions,{ | |||
| "/ban": "Ban player", | |||
| "/banspecs": "Ban all specs", | |||
| "/list": "List all the players and observers currently here", | |||
| "/clear": "Clear the chat comments" | |||
| "/clear": "Clear the chat comments", | |||
| "/jitsi": "meet.jit.si/anyNameYoutWantHere" | |||
There was a problem hiding this comment.
Bad description. Tell what is does, the use.
example: "Create a game videocall. Uses jitsi (meet.jit.si) service"
| // selfMessage(`meet.jit.si/anyNameYoutWantHere`); | ||
| selfMessage( | ||
| `Jitsi Meet is a fully encrypted, 100% open source video conferencing solution that you can use all day, every day, for free — with no account needed.` | ||
| ) | ||
|
|
||
|
|
||
| let gitHubLinkAutoCivModificationSL5 = 'https://github.com/sl5net/autociv'; | ||
|
|
||
| let textBest = `Jitsi is best for having a quick team call without setup process. could used as audio chat for you 0ad-team. ` | ||
| selfMessage( | ||
| textBest | ||
| ) | ||
|
|
||
| selfMessage( | ||
| `write /link to open a link in your WebBrowser if you have autoCiv-mod installed to open a link more easy.` | ||
| ) |
There was a problem hiding this comment.
Remove all this, not necessary for the user
There was a problem hiding this comment.
i need to explain very often to user what it is. so i don't want remove it.
| let linkTeam1example = `https://meet.jit.si/0ad${linkidShort}team123` | ||
| selfMessage( | ||
| ` recommendation: send later in your private team-game-chat a other unique link for audio chat. Example: ${linkTeam1example}` | ||
| ) | ||
|
|
||
| selfMessage( | ||
| ` this autoCiv-mod modification you could donwload here: ${gitHubLinkAutoCivModificationSL5}` | ||
| ) |
There was a problem hiding this comment.
Remove also, unnecessary for the user.
There was a problem hiding this comment.
its useful information for the user
| let population = 250 | ||
| game.set.population(population) | ||
|
|
||
| g_GameSettings.startingResources.resources = 200 | ||
| game.updateSettings() | ||
|
|
||
| selfMessage(linkLong) |
There was a problem hiding this comment.
Remove, this is not part of the command
There was a problem hiding this comment.
you are right. its not match to the title of the command.
| // let gameTextJitsiExplainded = `want use Jitsi as a fully encrypted, open source video conferencing, with no account needed.` | ||
| // gameText = ` ${textBest} ${linkLong} `; | ||
| let gameText = `jitsi | ${textBest} ${linkLong}` | ||
| return setGameNameInLobby(gameText); |
There was a problem hiding this comment.
This is also not part of the command
There was a problem hiding this comment.
the idea is that is visible from outside.
|
Looking at the feature itself and functionality I think it doesn't make sense to add it as a command. To me it looks easier just to share the link with other people directly and you still have the problem of sharing it. Thanks for the effort. But, sorry, won't merge in the current form. An more promising idea would be to have an GUI integration where all the players have a "button" to join the host jit.si session but this can't be done with a mod if you want all players to have it (I recommend asking the official 0ad team for that) Cheers and thanks. |
adds a jitsi command in the game setup.
it generates a unique but short, human readable jitsi-link and opens it.
then renames the looby name with included jitsi link.