Implement draw.polygon() API
#148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntoDrawn implementation.
This allows to avoid submitting the primitive for drawing when `drop` is called on the `Drawing` withing the `map` methods.
This gives more flexibility to implementations of the **IntoDrawn** trait as the **Vertices** types no longer require `Iterator<Item = Point>` and now have access to the **GeomVertexData** when yeilding each vertex. Closes nannou-org#146.
`draw.polygon()` now works as expected.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involved a large update to the inner IntoDrawn API used for mapping
Drawings of geometric primitives to their "meshed" representation. The overhaul now allows for a dynamic number of arbitrary vertices per drawn primitive without requiring the need to reallocate buffers on each draw call.The
DrawingAPI has also been updated to allow for builders to produce newDrawingtypes. This allows for typed ordering of builder methods. E.g.draw.polygon().points(points)produces aDrawing<Polygon<Fill>>which implementsSetColor, whiledraw.polygon().colored_points(points)produces aDrawing<Polygon<PerVertex>>which does not (as the color is specified via the vertices).draw.polygon()supports both "filled" coloring and per-vertex coloring. Asimple_polygon.rsexample has been added demonstrating the new feature.See the commit messages below for more details.