Moved values around

nano-byte · Jul 11, 2024 · 8c47f48 · 8c47f48
1 parent c50dac0
commit 8c47f48
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/charts/generic-service/README.md b/charts/generic-service/README.md
@@ -160,11 +160,11 @@ app:
 | `alerting.http.max5xxCount`                     | `0`                         | The maximum number of HTTP 5xx responses (except 504) in the sample interval                             |
 | `alerting.http.maxTimeoutCount`                 | `0`                         | The maximum number of HTTP gateway timeout responses (504) in the sample interval                        |
 | `alerting.grpc.requestsMetric`                  | `grpc_server_handled_total` | The name of the Prometheus metric counting gRPC requests                                                 |
-| `alerting.grpc.ignoreErrorCodes`                | `[]`                        | Which non-successful gRPC status codes will be ignored for triggering alerts                             |
 | `alerting.grpc.sampleInterval`                  | `20m`                       | The time interval in which to measure gRPC responses                                                     |
 | `alerting.grpc.referenceInterval`               | `1w`                        | The time interval to compare with the sample interval to detect changes                                  |
 | `alerting.grpc.maxErrorRatio`                   | `2.5`                       | The maximum gRPC error ratio increase in the sample interval compared to the reference interval          |
 | `alerting.grpc.errorDuration`                   |                             | The duration for which the gRPC error rate has to remain elevated before triggering an alert             |
+| `alerting.grpc.ignoreErrorCodes`                | `[]`                        | Which non-OK gRPC status codes will be ignored for triggering alerts                                     |
 | `alerting.grpc.maxCriticalErrors`               | `0`                         | The maximum number of critical gRPC errors responses in the sample interval                              |
 | `alerting.grpc.criticalCodes`                   | `[Internal, Unimplemented]` | Which gRPC status codes are considered critical errors                                                   |
 | `alerting.custom.*.metric`                      | __required if used__        | The name of the Prometheus metric exposed by the service                                                 |

diff --git a/charts/generic-service/values.schema.json b/charts/generic-service/values.schema.json
@@ -907,12 +907,6 @@
               "default": "grpc_server_handled_total",
               "description": "The name of the Prometheus metric counting gRPC requests"
             },
-            "ignoreErrorCodes": {
-              "type": "array",
-              "items": {"type": "string"},
-              "default": [],
-              "description": "Which non-successful gRPC status codes will be ignored for triggering alerts"
-            },
             "sampleInterval": {
               "type": "string",
               "default": "15m",
@@ -933,6 +927,12 @@
                 "default": "",
                 "description": "The duration for which the gRPC error rate has to remain elevated before triggering an alert"
             },
+            "ignoreErrorCodes": {
+              "type": "array",
+              "items": {"type": "string"},
+              "default": [],
+              "description": "Which non-OK gRPC status codes will be ignored for triggering alerts"
+            },
             "maxCriticalErrors": {
               "type": "integer",
               "default": 0,

diff --git a/charts/generic-service/values.yaml b/charts/generic-service/values.yaml
@@ -176,10 +176,10 @@ alerting:
     maxTimeoutCount: 0
   grpc:
     requestsMetric: grpc_server_handled_total
-    ignoreErrorCodes: []
     sampleInterval: 20m
     referenceInterval: 1w
     maxErrorRatio: 2.5
+    ignoreErrorCodes: []
     maxCriticalErrors: 0
     criticalCodes: [Internal, Unimplemented]
   custom: {}