feat: do not create LokiRule by default

nano-byte · Jan 15, 2024 · d8cdb8c · d8cdb8c
1 parent 2c9a95f
commit d8cdb8c
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 3 deletions.
diff --git a/charts/generic-service/ci/log-alerts-both-values.yaml b/charts/generic-service/ci/log-alerts-both-values.yaml
@@ -12,6 +12,7 @@ alerting:
         severity: Warning
         maxCount: 10
       error: {}
+    createLokiRule: true
     lokiConfigMap:
       label: "loki_rule"
       labelValue: ""
diff --git a/charts/generic-service/ci/log-alerts-operator-values.yaml b/charts/generic-service/ci/log-alerts-operator-values.yaml
@@ -14,3 +14,4 @@ alerting:
       error: {}
     # setting this to an empty object (`{}`) will not suppress cm creation, use `null` instead
     lokiConfigMap: null
+    createLokiRule: true
diff --git a/charts/generic-service/ci/log-alerts-sidecar-values.yaml b/charts/generic-service/ci/log-alerts-sidecar-values.yaml
@@ -15,4 +15,3 @@ alerting:
     lokiConfigMap:
       label: "loki_rule"
       labelValue: ""
-    createLokiRule: false
diff --git a/charts/generic-service/values.schema.json b/charts/generic-service/values.schema.json
@@ -956,7 +956,7 @@
             },
             "createLokiRule": {
               "type": "boolean",
-              "default": true,
+              "default": false,
               "description": "Whether to create a LokiRule CR for log alerting or not."
             }
           },

diff --git a/charts/generic-service/values.yaml b/charts/generic-service/values.yaml
@@ -179,7 +179,7 @@ alerting:
     countInterval: 5m
     levelLabel: level
     levels: {}
-    createLokiRule: true
+    createLokiRule: false
     lokiConfigMap:
       label: "loki_rule"
       labelValue: ""