Skip to content
This repository has been archived by the owner on Oct 16, 2020. It is now read-only.

[Enhancement] Pinging site rules in filter list page #37

Closed
KonoromiHimaries opened this issue Dec 14, 2017 · 6 comments
Closed

[Enhancement] Pinging site rules in filter list page #37

KonoromiHimaries opened this issue Dec 14, 2017 · 6 comments
Labels
archived This thread was archived, open new issues for similar problems. wontfix

Comments

@KonoromiHimaries
Copy link

KonoromiHimaries commented Dec 14, 2017

to check this site rule is it available or broken

example.
2017-12-14 08_54_36-nano filter viewer

i can't find any tool to check for availability the website


Nano Adblocker 1.0.0.12
Nano Defender 13.0
Chrome 63.0.3239.84

@KonoromiHimaries KonoromiHimaries changed the title [Enchancement] Pinging site in filter list page [Enhancement] Pinging site in filter list page Dec 14, 2017
@jspenguin2017
Copy link
Member

Yes, that is a good idea, although how to implement that is a whole other story.

@KonoromiHimaries KonoromiHimaries changed the title [Enhancement] Pinging site in filter list page [Enhancement] Pinging rules in filter list page Dec 16, 2017
@KonoromiHimaries KonoromiHimaries changed the title [Enhancement] Pinging rules in filter list page [Enhancement] Pinging site rules in filter list page Dec 16, 2017
@NanoAi
Copy link

NanoAi commented Dec 19, 2017

Found this ( https://jsfiddle.net/GSSCD/203/ ) fiddle thought it may help, it pretty much tries to load the website as an invisible image and is able to see if the site is responsive like that. (Although that could have some other issues such as privacy etc.)

@jspenguin2017
Copy link
Member

jspenguin2017 commented Dec 19, 2017

The problem is not pinging the website, it's how to integrate that into the editor.
Since it's activated by the user, there is no privacy issue.

@jspenguin2017
Copy link
Member

jspenguin2017 commented Feb 4, 2018

I don't see much point in implementing a pinging system. If you want to see if that website is up, double click to select it (it's working now), and drag it to the tabs bar to open it. If you need mass scanning, you should use a native script, which gives you way more control and flexibility. You can forge any header you like, and send the request the way you like.

@elypter
Copy link

elypter commented Feb 4, 2018

this is something for a server side list manager like what filterlists.com intends to become.

@jspenguin2017
Copy link
Member

jspenguin2017 commented Feb 4, 2018

I don't think it's a good idea to give them too much power. Being able to remove any rules they like from filter lists is too much authority.

I think a tool to quickly lookup which domains are no longer resolvable is a good idea. Although there are catches where ads.example.com resolves but example.com doesn't.

Sending test requests will likely to not work from servers, as it's rather easy to know which requests come from data centers. I guess distributing the task of scanning for obsolete filters isn't a bad idea, but that's for another (native) app or extension.

@github-actions github-actions bot added the archived This thread was archived, open new issues for similar problems. label Aug 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived This thread was archived, open new issues for similar problems. wontfix
Projects
None yet
Development

No branches or pull requests

4 participants