Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for VS2015 and CMake 3.0 #9

Merged
merged 1 commit into from Jul 21, 2018

Conversation

cdglove
Copy link
Contributor

@cdglove cdglove commented Dec 4, 2015

  • Use full paths to include files and pch files.
  • Link to output lib for MSVC 2015
  • Add missing CMake 3.0.2+ flags.

There might be a better way of doing this (I'm not a cmake guru), but this changes for things working for me.

- Link to output lib for MSVC 2015
- Add missing CMake 3.0.2+ flags.
set_source_files_properties(
${header}
PROPERTIES
LANGUAGE ${lang}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to have the lang as CXX for VS for some reason or the file would not be built.

@m4c0
Copy link

m4c0 commented Sep 23, 2016

Doesn't it means we need to change cmake_minimum_required to 3.0.x?

@onqtam
Copy link

onqtam commented Sep 23, 2016

@m4c0 cmake 3.0 is already old so it shouldn't be a problem

@onqtam
Copy link

onqtam commented Nov 25, 2016

I cannot stress enough how important sharing precompiled headers between targets is to me... (500 plugins as .dlls)

Is this project even alive? Add a donate button and I will donate...

@nanoant
Copy link
Owner

nanoant commented Nov 25, 2016

It is not really dead, but neither fully alive ;) I have new job and right now I am kind of overwhelmed by my new duties, however I will have a look at these PRs this weekend and see what I can do.
Moreover my solution (this project) is kind of workaround. Proper solution would be to somehow make CMake itself to be aware of precompiled headers, rather use the tricks. This was somehow proposed to KitWare, but never made through.

m-7761 pushed a commit to m-7761/CMakePCHCompiler that referenced this pull request Jul 12, 2017
@m-7761 m-7761 mentioned this pull request Jul 20, 2018
@nanoant nanoant merged commit 39c7deb into nanoant:master Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants