-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows growlnotify support #267
Add Windows growlnotify support #267
Conversation
It’s probably also a good idea to move the watcher into a separate object, maybe Those changes belong in a separate pull request though. Stay tuned. |
I’ll fix this later in a decent way. I’m refactoring the watcher quite significantly, and this pull request will be obsolete once I’m finished with that. |
Since the watcher refactoring was cancelled (see #293), I think reopening this pull request makes sense. I have no clue how to test this automatically. Maybe it isn’t automatically testable. Any ideas? @bobthecow? @agross Can you test (manually) whether this pull requests works for you? If it does, it could be merged without presence of automated tests. |
@ddfreyne I'll test that either tomorrow or on Tuesday. As for testing, why not check if nanoc builds the command line parameters correctly and calls |
@ddfreyne I left a comment on denisdefreyne/nanoc@43a49c9cf3. If the typo is fixed, it will work. As always, thank you very much! |
Awesome. I’ll add a test and release this in 3.6.3! |
@bobthecow Review, merge and close #253 afterwards. |
Add Windows growlnotify support
This fixes #253.
This is a work in progress. There are no tests yet, and I have no clear idea of how I would test this. Perhaps create a stub
growlnotify
executable and see whether it is called the right way.