Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag pages #803

Closed
floreal opened this issue Jan 17, 2016 · 1 comment
Closed

tag pages #803

floreal opened this issue Jan 17, 2016 · 1 comment

Comments

@floreal
Copy link

@floreal floreal commented Jan 17, 2016

Hi, I wrote this: https://gist.github.com/floreal/58826423f29efbaa2a67
But that I need to call create_tag_pages in preporcess section of Rules file. I'd like to turn it into a datasorce so that this call wouldn't be needed anymore and then I could make a pull request.

The problem I need other datasources before using that one so that reading tags will be easy using @items variable.

Do you think there is a way to do it ?
Would it need a big change in nanoc codebase ?
Or should I provide a pull request with this snippet as is even if end user will need to use preprocess section in his Rules file ?

Cheers

@floreal floreal changed the title tags page tag pages Jan 17, 2016
@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Jan 23, 2016

Data sources aren’t designed to generate items (or layouts) based on what other data sources provide.

The recommended approach is to do what you are already doing, which is using the preprocessor to generate these pages.

@ddfreyne ddfreyne closed this Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants