Fix cycle detection in item rep selector #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
force-pushed
the
denis/fix-cycle-detection
branch
from
55f7301
to
9b5c032
Compare
denisdefreyne
force-pushed
the
denis/fix-cycle-detection
branch
from
9b5c032
to
d9950b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
This replaces the stack-based dependency cycle detector with one that actually works. See the newly added specs for
ItemRepPriorityQueuewhich demonstrate the #1619 regression.To do
It’s possible for the
ItemRepPriorityQueueto yield an item even if it has already been yielded before and marked as OK. This isn’t the worst: it’s still correct, but certainly inefficient. Fix it anyway.(After merge) Update the compilation order documentation on the web site.
Related issues
Fixes #1619.