Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent double slash when using extra_files #1622

Merged
merged 1 commit into from Nov 15, 2022

Conversation

denisdefreyne
Copy link
Member

@denisdefreyne denisdefreyne commented Nov 15, 2022

Detailed description

The Troubleshooting page gives instructions for what to do when hidden files are ignored. The example given is as follows:

data_sources:
  -
    type: filesystem
    extra_files:
      - "/.well-known/**/*"
      - "/.nojekyll"

However, this example is not currently working as intended: the extra files end up with double slashes at the beginning (e.g. //.nojekyll).

This PR fixes that.

To do

  • Tests

The troubleshooting documentation could also be updated, though if both variants (starting with slash and not starting with slash) are supported, the documentation is fine anyway.

Related issues

n/a

@denisdefreyne denisdefreyne marked this pull request as ready for review November 15, 2022 19:10
@denisdefreyne denisdefreyne merged commit cc2e8ca into main Nov 15, 2022
@denisdefreyne denisdefreyne deleted the denis/extra-files-leading-slash branch November 15, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant