Let Store#store support large amounts of data #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ignore the test failure. Apparently GitHub Actions does not like me using this many resources to run tests 😂 |
denisdefreyne
force-pushed
the
denis/reliable-bin-write
branch
from
8e66ff3
to
b5f5c0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
IO.writecan raise the errorInvalid argument @ io_writewhen there is too much data to write.This PR changes
#write_obj_to_fileto write data as a stream, usingIO.copy_stream. Additionally, the file is written atomically (written to temp file and then moved into place).To do
Related issues
Fixes #1635.