Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error handler print #full_message if available #1657

Merged
merged 1 commit into from Jun 24, 2023

Conversation

denisdefreyne
Copy link
Member

Detailed description

If an error implements #full_message, it will be printed after the error detail. This makes the nanoc-dart-sass errors much more interesting:

Captain! We’ve been hit!

Sass::CompileError: Undefined mixin.

Error: Undefined mixin.
  ╷
9 │   @include oops;
  │   ^^^^^^^^^^^^^
  ╵
  nanoc:/assets/style/_2021q4_common.* 9:3  @use
  - 7:1                                     root stylesheet

Current item: /assets/style/2021q4.scss (:default representation)

To do

  • Tests

Related issues

n/a

@denisdefreyne denisdefreyne marked this pull request as ready for review June 18, 2023 08:29
@DivineDominion
Copy link

Tested in my project, looks great 👍

@denisdefreyne denisdefreyne merged commit ad5e4c1 into main Jun 24, 2023
4 checks passed
@denisdefreyne denisdefreyne deleted the denis/error-detail branch June 24, 2023 08:19
@denisdefreyne
Copy link
Member Author

This is released in 4.12.16 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants