Set metadata source_code_uri #1669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds 'source_code_uri' key to gemspec's metadata, which makes nanoc and the plugins compatible with [gem-src](https://rubygems.org/gems/gem-src)'s functionality: without it there is no way to detect the source repo unless actually opening the homepage and navigate through it, which I believe is rather tedious. The 'source_code_uri' item in gemspec's metadata is described in [the guideline rubygems.org publishes](https://guides.rubygems.org/specification-reference/#metadata), and it is [what gem-src uses to prioritize when inferring which repo to clone](https://github.com/amatsuda/gem-src/blob/v0.10.2/lib/rubygems_plugin.rb#L38).
|
@sato11 Thank you! I made two changes:
In any case, the change is merged! |
|
This is released in Nanoc 4.12.19. |
|
@denisdefreyne Thanks for your passionate work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds 'source_code_uri' key to gemspec's metadata, which makes nanoc and the plugins compatible with gem-src's functionality: without it there is no way to detect the source repo unless actually opening the homepage and navigate through it, which I believe is rather tedious.
The 'source_code_uri' item in gemspec's metadata is described in the guideline rubygems.org publishes, and it is what gem-src uses to prioritize when inferring which repo to clone.
I guess there are not many who have come across this issue, but what do you think of it anyway?
And last but not least, thanks for letting me have a chance to touch your product. I have had a lot of fun and I appreciate your effort 馃