Return of the YAML aliases :) #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Fix for configuration-breaking change) Fixes breaking changes in YAML processing, [Issue nanoc#1676] [Issue nanoc#1676]: nanoc#1676 Broken upstream with Psych 4 (https://bugs.ruby-lang.org/issues/17866) and reinforced in Nanoc with [PR 1583](nanoc#1583), commit `8882be18101315c7c65ee88dded328d3d44b30db`. #### Details Psych 4 has introduced a [severe breaking change](https://bugs.ruby-lang.org/issues/17866) - YAML anchors and aliases are no longer recognized by default. Nanoc enforces Psych >= 4 since [PR 1583](nanoc#1583), commit `8882be18101315c7c65ee88dded328d3d44b30db`. This prevents `gem 'psych', '<4'` as first aid in one's own Gemfile. Net result: All `nanoc.yaml` configurations and content front matters that make use of anchors are since broken.
Reason: Single responsibility.
zor-el
changed the title
zor-el
changed the title
The GitHub CI pipeline errored out unexpectedly, even though I did follow the [official code contribution workflow] (including `bundle exec rake test`). The error seems to indicate (somewhat convolutedly) the need to add the new module to nanoc-core.manifest. I'm giving this a try. [nanoc#375]: https://github.com/nanoc/nanoc/actions/runs/7068481942 [official code contribution workflow]: https://nanoc.app/contributing/
|
@denisdefreyne, hey, I've updated the PR in an attempt to fix the CI issue. Would you like to give it another nudge? |
|
@zor-el Looks like there are some Rubocop changes that break |
|
@zor-el Thank you! |
|
@zor-el This is released as 4.12.19 today. I credited you as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @denisdefreyne, it's been a long time since we've last been in touch. How are you? :)
Detailed description
This is the fix for #1676. See details there.
FYI, the last commit is solely a refactoring to establish single responsibility for YAML parser invocations, while the prior commits fix the invocations in the multiple places where they occurred.
3 commits:
nanoc.yaml=> single responsibility, less verbose YAML access, centrally testable (test included)