Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Rouge syntax colorizer - issue #275 #398

Merged
merged 1 commit into from Mar 15, 2014

Conversation

Projects
None yet
3 participants
@ggarnier
Copy link
Contributor

commented Mar 14, 2014

Adding a new colorizer implementation for Rouge - issue #275

@ddfreyne ddfreyne added the feature label Mar 15, 2014

@ddfreyne ddfreyne merged commit 2d9a7b9 into nanoc:master Mar 15, 2014

1 check failed

default The Travis CI build could not complete due to an error
Details
@ddfreyne

This comment has been minimized.

Copy link
Member

commented Mar 15, 2014

Cool stuff, thanks!

@gjtorikian

This comment has been minimized.

Copy link
Member

commented May 6, 2014

I was looking forward to use this. It doesn't appear to be in the most recent release of 3.6.9. Is that intentional?


Message:

RuntimeError: I don’t know how to highlight code using the “rouge” colorizer

Compilation stack:

  - [item]   /changes/2013-10-04-oauth-changes-coming/ (rep default)

Stack trace:

  0. /Users/garentorikian/github/internal-developer.github.com/vendor/gems/ruby/1.9.1/gems/nanoc-3.6.9/lib/nanoc/filters/colorize_syntax.rb:330:in `highlight'
  1. /Users/garentorikian/github/internal-developer.github.com/vendor/gems/ruby/1.9.1/gems/nanoc-3.6.9/lib/nanoc/filters/colorize_syntax.rb:127:in `block in run'
  2. /Users/garentorikian/github/internal-developer.github.com/vendor/gems/ruby/1.9.1/gems/nokogiri-1.6.1/lib/nokogiri/xml/node_set.rb:237:in `block in each'
  3. /Users/garentorikian/github/internal-developer.github.com/vendor/gems/ruby/1.9.1/gems/nokogiri-1.6.1/lib/nokogiri/xml/node_set.rb:236:in `upto'
  4. /Users/garentorikian/github/internal-developer.github.com/vendor/gems/ruby/1.9.1/gems/nokogiri-1.6.1/lib/nokogiri/xml/node_set.rb:236:in `each'
  5. /Users/garentorikian/github/internal-developer.github.com/vendor/gems/ruby/1.9.1/gems/nanoc-3.6.9/lib/nanoc/filters/colorize_syntax.rb:106:in `run'
  6. /Users/garentorikian/github/internal-developer.github.com/vendor/gems/ruby/1.9.1/gems/nanoc-3.6.9/lib/nanoc/base/compilation/filter.rb:122:in `setup_and_run'
  7. /Users/garentorikian/github/internal-developer.github.com/vendor/gems/ruby/1.9.1/gems/nanoc-3.6.9/lib/nanoc/base/result_data/item_rep.rb:344:in `filter'
  8. /Users/garentorikian/github/internal-developer.github.com/vendor/gems/ruby/1.9.1/gems/nanoc-3.6.9/lib/nanoc/base/compilation/item_rep_proxy.rb:47:in `filter'
  9. /Users/garentorikian/github/internal-developer.github.com/vendor/gems/ruby/1.9.1/gems/nanoc-3.6.9/lib/nanoc/base/compilation/rule_context.rb:61:in `filter'
  ... 28 more lines omitted. See full crash log for details.

@ddfreyne

This comment has been minimized.

Copy link
Member

commented May 6, 2014

@gjtorikian It’s not in 3.6.x, but it’ll be in 3.7.0, which I plan on releasing in the next two weeks.

@gjtorikian

This comment has been minimized.

Copy link
Member

commented May 6, 2014

👍 Thanks!

@gjtorikian

This comment has been minimized.

Copy link
Member

commented Jun 8, 2014

Sorry to be rude, but, I'm interested in using Rouge for developer.github.com. I was wondering if 3.7 was landing soon?

Thanks and ❤️.

@ddfreyne

This comment has been minimized.

Copy link
Member

commented Jun 8, 2014

Sorry, I am notoriously bad at releasing quickly!

I believe there’s not much else left for 3.7, so I’ll get it released this weekend!

@ddfreyne

This comment has been minimized.

Copy link
Member

commented Jun 8, 2014

Releasing this depends on fixing #443. Reviews welcome!

@ddfreyne

This comment has been minimized.

Copy link
Member

commented Jun 8, 2014

3.7.0 is released!

I’d close this issue if it weren’t closed already!

@gjtorikian

This comment has been minimized.

Copy link
Member

commented Jun 8, 2014

You're the best; I know what it's like to manage an OSS project so I apologize for prodding! 😻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.