New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bound recursive checksumming #518

Merged
merged 1 commit into from Jan 11, 2015

Conversation

Projects
None yet
2 participants
@ddfreyne
Member

ddfreyne commented Jan 10, 2015

Fix for #469. Instead of preventing items and layouts in attributes, we can allow them and let the checksummer properly deal with it.

PR #507 had a different implementation, but too much like a hack.

digest.update(obj.class.to_s)
if visited.include?(obj)
digest.update('recur')

This comment has been minimized.

@mpapis

mpapis Jan 10, 2015

Member

if visited would be a hash then we could store also the digest value and set it here, would it be useful at all?

@mpapis

mpapis Jan 10, 2015

Member

if visited would be a hash then we could store also the digest value and set it here, would it be useful at all?

This comment has been minimized.

@ddfreyne

ddfreyne Jan 10, 2015

Member

We can’t set the digest value because at the time it isn’t known yet.

@ddfreyne

ddfreyne Jan 10, 2015

Member

We can’t set the digest value because at the time it isn’t known yet.

This comment has been minimized.

@mpapis

mpapis Jan 10, 2015

Member

ah I see it now, painful

@mpapis

mpapis Jan 10, 2015

Member

ah I see it now, painful

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Jan 11, 2015

Member

Can I get a +1?

Member

ddfreyne commented Jan 11, 2015

Can I get a +1?

@mpapis

This comment has been minimized.

Show comment
Hide comment
@mpapis

mpapis Jan 11, 2015

Member

looks good but the jruby test failed, I have restarted it to check if it was one time or an real problem

Member

mpapis commented Jan 11, 2015

looks good but the jruby test failed, I have restarted it to check if it was one time or an real problem

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Jan 11, 2015

Member

Tests are passing on Travis CI, but GitHub isn’t picking up the success. Odd!

Member

ddfreyne commented Jan 11, 2015

Tests are passing on Travis CI, but GitHub isn’t picking up the success. Odd!

@ddfreyne ddfreyne removed the to review label Jan 11, 2015

ddfreyne added a commit that referenced this pull request Jan 11, 2015

@ddfreyne ddfreyne merged commit e3b0740 into release-3.7.x Jan 11, 2015

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

@ddfreyne ddfreyne deleted the bounded-recursive-checksumming branch Jan 11, 2015

ddfreyne added a commit that referenced this pull request Jan 11, 2015

ddfreyne added a commit that referenced this pull request Jan 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment