Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bound recursive checksumming #518

Merged
merged 1 commit into from Jan 11, 2015
Merged

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Jan 10, 2015

Fix for #469. Instead of preventing items and layouts in attributes, we can allow them and let the checksummer properly deal with it.

PR #507 had a different implementation, but too much like a hack.

@ddfreyne ddfreyne force-pushed the bounded-recursive-checksumming branch from dcbc5da to 2bcf98b Jan 10, 2015
digest.update(obj.class.to_s)

if visited.include?(obj)
digest.update('recur')
Copy link
Member

@mpapis mpapis Jan 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if visited would be a hash then we could store also the digest value and set it here, would it be useful at all?

Loading

Copy link
Member Author

@ddfreyne ddfreyne Jan 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can’t set the digest value because at the time it isn’t known yet.

Loading

Copy link
Member

@mpapis mpapis Jan 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see it now, painful

Loading

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Jan 11, 2015

Can I get a +1?

Loading

@mpapis
Copy link
Member

@mpapis mpapis commented Jan 11, 2015

looks good but the jruby test failed, I have restarted it to check if it was one time or an real problem

Loading

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Jan 11, 2015

Tests are passing on Travis CI, but GitHub isn’t picking up the success. Odd!

Loading

ddfreyne added a commit that referenced this issue Jan 11, 2015
@ddfreyne ddfreyne merged commit e3b0740 into release-3.7.x Jan 11, 2015
1 check was pending
Loading
@ddfreyne ddfreyne deleted the bounded-recursive-checksumming branch Jan 11, 2015
ddfreyne added a commit that referenced this issue Jan 11, 2015
ddfreyne added a commit that referenced this issue Jan 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants