Bound recursive checksumming #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
force-pushed
the
bounded-recursive-checksumming
branch
from
dcbc5da
to
2bcf98b
Compare
| digest.update(obj.class.to_s) | ||
|
|
||
| if visited.include?(obj) | ||
| digest.update('recur') |
There was a problem hiding this comment.
if visited would be a hash then we could store also the digest value and set it here, would it be useful at all?
There was a problem hiding this comment.
We can’t set the digest value because at the time it isn’t known yet.
|
Can I get a +1? |
|
looks good but the jruby test failed, I have restarted it to check if it was one time or an real problem |
|
Tests are passing on Travis CI, but GitHub isn’t picking up the success. Odd! |
denisdefreyne
added a commit
that referenced
this pull request
Jan 11, 2015
Bound recursive checksumming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #469. Instead of preventing items and layouts in attributes, we can allow them and let the checksummer properly deal with it.
PR #507 had a different implementation, but too much like a hack.