New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not upload files with identical etags #552

Merged
merged 1 commit into from May 31, 2015

Conversation

Projects
None yet
1 participant
@ddfreyne
Member

ddfreyne commented May 4, 2015

This is continued off #480. Replaces #536 (code identical, but this time on master instead of release-3.7.x).

This PR has quite a bit of extra tests and refactorings that make these tests possible. I also tested this with an actual S3 and can confirm that it works.

ddfreyne added a commit that referenced this pull request May 31, 2015

Merge pull request #552 from nanoc/aws-deploy-md5-v2
Do not upload files with identical etags

@ddfreyne ddfreyne merged commit 7a176ec into master May 31, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@ddfreyne ddfreyne deleted the aws-deploy-md5-v2 branch May 31, 2015

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne May 31, 2015

Member

Got a +1 before the extra tests, so I’m assuming that’s fine now too. I tested it and it works anyway :)

Member

ddfreyne commented May 31, 2015

Got a +1 before the extra tests, so I’m assuming that’s fine now too. I tested it and it works anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment