Build the reps in the show commands so they can be described #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the `show-rules` command.
cdchapman
changed the title
|
Thanks for the fix! The issue with item reps not being filled in has popped up before, and I’ll see what I can do to make this less likely to happen. |
denisdefreyne
added a commit
that referenced
this pull request
Oct 29, 2016
|
I added two additional high-level regression tests in 7ffd07c. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
show-{data,rules}commands do not load or describe the item reps. This pull request builds the reps in the setup of the command so they can be described.To do
show-rulesshow-dataDetailed description
The
show-{data,rules}commands do not load or describe the item reps, so the methods that use the reps in these commands are actually operating on an emptyNanoc::Int::ItemRepRepoand do not output anything helpful.I'm not sure whether this is the best way to accomplish loading the reps, but this simple change enables these two commands to work as expected.
About the lack of tests, the existing test forLooking closer at the tests (sorry I goofed), the setup is mocked. I've added a block to expect thatshow-rulescreates stubs for the item reps, and does not test the actual setup of the command. I'm willing to create tests for this if you can give me some direction.build_repsis called.Anyways, thanks for a great project!