Batch erase in unchecked_cleanup due to a potentially large list

nano/node/node.cpp

@@ -933,7 +933,7 @@ void nano::node::bootstrap_wallet ()
 
 void nano::node::unchecked_cleanup ()
 {
-	std::vector<std::shared_ptr<nano::block>> blocks;
+	std::vector<nano::uint128_t> digests;
 	std::deque<nano::unchecked_key> cleaning_list;
 	auto attempt (bootstrap_initiator.current_attempt ());
 	bool long_attempt (attempt != nullptr && std::chrono::duration_cast<std::chrono::seconds> (std::chrono::steady_clock::now () - attempt->attempt_start).count () > config.unchecked_cutoff_time.count ());
@@ -949,7 +949,7 @@ void nano::node::unchecked_cleanup ()
 			nano::unchecked_info const & info (i->second);
 			if ((now - info.modified) > static_cast<uint64_t> (config.unchecked_cutoff_time.count ()))
 			{
-				blocks.push_back (info.block);
+				digests.push_back (network.publish_filter.hash (info.block));
 				cleaning_list.push_back (key);
 			}
 		}
@@ -976,10 +976,7 @@ void nano::node::unchecked_cleanup ()
 		}
 	}
 	// Delete from the duplicate filter
-	for (auto const & block : blocks)
-	{
-		network.publish_filter.clear (block);
-	}
+	network.publish_filter.clear (digests);
 }
 
 void nano::node::ongoing_unchecked_cleanup ()

nano/secure/network_filter.cpp

@@ -98,4 +98,5 @@ nano::uint128_t nano::network_filter::hash (uint8_t const * bytes_a, size_t coun
 }
 
 // Explicitly instantiate
+template nano::uint128_t nano::network_filter::hash (std::shared_ptr<nano::block> const &) const;
 template void nano::network_filter::clear (std::shared_ptr<nano::block> const &);