Consistency in calls to fanout() and using const ref for flood_vote*

nanocurrency · Jan 21, 2020 · 82c6cf5 · 82c6cf5
1 parent 7d83472
commit 82c6cf5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/nano/core_test/peer_container.cpp b/nano/core_test/peer_container.cpp
@@ -131,13 +131,13 @@ TEST (peer_container, list_fanout)
 	};
 	add_peer (9998);
 	ASSERT_EQ (1, node.network.size ());
-	ASSERT_EQ (1.0, node.network.size_sqrt ());
+	ASSERT_EQ (1.f, node.network.size_sqrt ());
 	ASSERT_EQ (1, node.network.fanout ());
 	auto list2 (node.network.list (node.network.fanout ()));
 	ASSERT_EQ (1, list2.size ());
 	add_peer (9999);
 	ASSERT_EQ (2, node.network.size ());
-	ASSERT_EQ (std::sqrt (2.F), node.network.size_sqrt ());
+	ASSERT_EQ (std::sqrt (2.f), node.network.size_sqrt ());
 	ASSERT_EQ (2, node.network.fanout ());
 	auto list3 (node.network.list (node.network.fanout ()));
 	ASSERT_EQ (2, list3.size ());

diff --git a/nano/node/network.cpp b/nano/node/network.cpp
@@ -220,7 +220,7 @@ void nano::network::flood_message (nano::message const & message_a, bool const i
 	}
 }
 
-void nano::network::flood_vote (std::shared_ptr<nano::vote> vote_a, float scale)
+void nano::network::flood_vote (std::shared_ptr<nano::vote> const & vote_a, float scale)
 {
 	nano::confirm_ack message (vote_a);
 	for (auto & i : list_non_pr (fanout (scale)))
@@ -229,7 +229,7 @@ void nano::network::flood_vote (std::shared_ptr<nano::vote> vote_a, float scale)
 	}
 }
 
-void nano::network::flood_vote_pr (std::shared_ptr<nano::vote> vote_a)
+void nano::network::flood_vote_pr (std::shared_ptr<nano::vote> const & vote_a)
 {
 	nano::confirm_ack message (vote_a);
 	for (auto const & i : node.rep_crawler.principal_representatives ())
@@ -281,7 +281,7 @@ void nano::network::broadcast_confirm_req (std::shared_ptr<nano::block> block_a)
 	if (list->empty () || node.rep_crawler.total_weight () < node.config.online_weight_minimum.number ())
 	{
 		// broadcast request to all peers (with max limit 2 * sqrt (peers count))
-		auto peers (node.network.list (std::min<size_t> (100, node.network.fanout (2.F))));
+		auto peers (node.network.list (std::min<size_t> (100, node.network.fanout (2.0))));
 		list->clear ();
 		list->insert (list->end (), peers.begin (), peers.end ());
 	}

diff --git a/nano/node/network.hpp b/nano/node/network.hpp
@@ -105,8 +105,8 @@ class network final
 		random_fill (message.peers);
 		flood_message (message);
 	}
-	void flood_vote (std::shared_ptr<nano::vote>, float scale);
-	void flood_vote_pr (std::shared_ptr<nano::vote>);
+	void flood_vote (std::shared_ptr<nano::vote> const &, float scale);
+	void flood_vote_pr (std::shared_ptr<nano::vote> const &);
 	void flood_block (std::shared_ptr<nano::block> block_a, bool const is_droppable_a = true)
 	{
 		nano::publish publish (block_a);