Fix election calling confirm_if_quorum after destruction (#2563)

When insert_inactive_votes_cache confirms the election it deletes itself from the active roots, causing the next confirm_if_quorum call to access freed memory.
nanocurrency · Feb 17, 2020 · ec886e7 · ec886e7
1 parent 58080cc
commit ec886e7
Showing 1 changed file with 0 additions and 1 deletion.
diff --git a/nano/node/election.cpp b/nano/node/election.cpp
@@ -220,7 +220,6 @@ bool nano::election::publish (std::shared_ptr<nano::block> block_a)
 		{
 			blocks.emplace (std::make_pair (block_a->hash (), block_a));
 			insert_inactive_votes_cache (block_a->hash ());
-			confirm_if_quorum ();
 			node.network.flood_block (block_a, false);
 		}
 		else