Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update references to non-standard units in QT wallet #3386

Closed
zhyatt opened this issue Jul 21, 2021 · 1 comment
Closed

Update references to non-standard units in QT wallet #3386

zhyatt opened this issue Jul 21, 2021 · 1 comment
Assignees
@shryder
Labels
breaking Change to node APIs (separate label) which impacts existing implementation, integrations impacted. qt wallet Item related to the qt wallet rpc Changes related to Remote Procedure Calls semantic Change to node APIs (separate label) which impacts interpretation of data, integrations impacted.
Milestone
V23.0

Comments

@zhyatt
Copy link
Collaborator

zhyatt commented Jul 21, 2021 •
edited
Loading

Recent discussions on unit changes has arrived at keeping case insensitive nano (NANO, Nano) as 10^30 and raw as 10^0 for the main standardized units. To help set the standard, code references to units in the QT wallet and RPCs for unit conversion, need adjustments:

  • mnano/mrai should become nano
  • knano/krai should be removed
  • nano should be removed wherever it is used for 10^24 units
  • rai should be removed

For the unit conversion RPCs, all existing should be deprecated:

  • krai_from_raw, krai_to_raw
  • mrai_from_raw, mrai_to_raw
  • rai_from_raw, rai_to_raw

New unit conversion RPCs should be added:

  • nano_to_raw
  • raw_to_nano

nanocurrency/nano-docs#466 (comment)
@zhyatt zhyatt added qt wallet Item related to the qt wallet rpc Changes related to Remote Procedure Calls semantic Change to node APIs (separate label) which impacts interpretation of data, integrations impacted. breaking Change to node APIs (separate label) which impacts existing implementation, integrations impacted. labels Jul 21, 2021
@zhyatt zhyatt added this to the V23.0 milestone Jul 21, 2021
@zhyatt zhyatt assigned zhyatt and shryder and unassigned zhyatt Jul 22, 2021
shryder added a commit to shryder/nano-node that referenced this issue Jul 22, 2021
@shryder
Remove knano and mnano references from QT wallet nanocurrency#3386
d27869d
@shryder shryder mentioned this issue Jul 25, 2021
Merged
clemahieu pushed a commit that referenced this issue Jul 26, 2021
@shryder
Update RPC & QT Wallet to the new units #3386 (#3392)
88c87f7 
* Remove knano and mnano references from QT wallet #3386
@zhyatt
Copy link
Collaborator Author

zhyatt commented Jul 26, 2021

Closed by #3392

@zhyatt zhyatt closed this as completed Jul 26, 2021
@tombertrand tombertrand mentioned this issue Oct 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shryder shryder

Labels
breaking Change to node APIs (separate label) which impacts existing implementation, integrations impacted. qt wallet Item related to the qt wallet rpc Changes related to Remote Procedure Calls semantic Change to node APIs (separate label) which impacts interpretation of data, integrations impacted.
Projects
None yet
Milestone
V23.0
Development

No branches or pull requests
2 participants
@zhyatt @shryder