Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow local preconfigured peers #1105

Merged

Conversation

Projects
5 participants
@PlasmaPower
Copy link
Contributor

commented Aug 26, 2018

Untested

{
auto node_l (shared_from_this ());
network.resolver.async_resolve (boost::asio::ip::udp::resolver::query (address_a, std::to_string (port_a)), [node_l, address_a, port_a](boost::system::error_code const & ec, boost::asio::ip::udp::resolver::iterator i_a) {
network.resolver.async_resolve (boost::asio::ip::udp::resolver::query (address_a, std::to_string (port_a)), [node_l, preconfigured_peer_a, address_a, port_a](boost::system::error_code const & ec, boost::asio::ip::udp::resolver::iterator i_a) {

This comment has been minimized.

Copy link
@cryptocode

cryptocode Aug 26, 2018

Collaborator

Not specific to this PR, but this particular async_resolve overload is deprecated and will be removed (https://www.boost.org/doc/libs/1_67_0/doc/html/boost_asio/reference/ip__basic_resolver/async_resolve.html)

This comment has been minimized.

Copy link
@PlasmaPower

PlasmaPower Aug 26, 2018

Author Contributor

What should we use instead?

This comment has been minimized.

Copy link
@cryptocode

cryptocode Aug 26, 2018

Collaborator

One of the string_view overloads I think

@rkeene rkeene added the enhancement label Aug 26, 2018

@zhyatt zhyatt added this to the V18.0 milestone Jan 2, 2019

@SergiySW

This comment has been minimized.

Copy link
Collaborator

commented Jan 3, 2019

@SergiySW SergiySW added this to CP 2 (2018-01-16) in V18 Jan 3, 2019

SergiySW added some commits Jan 14, 2019

Fix
@SergiySW

This comment has been minimized.

Copy link
Collaborator

commented Jan 15, 2019

Require "allow_local_peers": "true" in config

@rkeene rkeene merged commit af1f6d0 into nanocurrency:master Jan 23, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.