Fix vote_cache #1362
Merged
Fix vote_cache #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemahieu
reviewed
Nov 8, 2018
rai/node/lmdb.cpp
Outdated
| { | ||
| std::lock_guard<std::mutex> lock (cache_mutex); | ||
| sequence_cache_l.swap (vote_cache); | ||
| vote_cache_l2 = vote_cache_l1; |
There was a problem hiding this comment.
Since we're checking both l1 and l2, do we need to copy this, it seems like a swap would still work.
At the end of the for-look that checks l2 we could clear l2.
There was a problem hiding this comment.
Since we're checking both l1 and l2, do we need to copy this, it seems like a swap would still work.
Yeah good point.
At the end of the for-look that checks l2 we could clear l2.
I believe that would result in worse performance. Also, we'd need to do it after the transaction expires, not at the end of the function.
clemahieu
reviewed
Nov 8, 2018
PlasmaPower
force-pushed
the
vote-cache-fix
branch
from
152cb2a
to
c7d0221
Compare
SergiySW
reviewed
Nov 8, 2018
SergiySW
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a second cache layer, so that the vote store remains consistent during flushing.
Fixes #1206