Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulate and lock stat_datapoint, fixes core_test tsan #1665

Merged
merged 1 commit into from Jan 30, 2019
Merged

Encapsulate and lock stat_datapoint, fixes core_test tsan #1665

merged 1 commit into from Jan 30, 2019

Conversation

cryptocode
Copy link
Contributor

@cryptocode cryptocode commented Jan 30, 2019 •
edited

Also a clang-format guard where versions disagree.

@cryptocode cryptocode added the unit test Related to a new, changed or fixed unit test label Jan 30, 2019
@cryptocode cryptocode added this to the V18.0 milestone Jan 30, 2019
@cryptocode cryptocode self-assigned this Jan 30, 2019
@cryptocode cryptocode added this to During RC in V18 Jan 30, 2019
@SergiySW
Copy link
Contributor

Strange miniupnp changes

SergiySW
SergiySW approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@SergiySW SergiySW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cryptocode cryptocode merged commit 70532b5 into nanocurrency:master Jan 30, 2019
@cryptocode cryptocode deleted the stats/encapsulate-data_point branch January 30, 2019 16:50
@zhyatt zhyatt moved this from RC2 to CP 3/RC 1 (2018-02-01) in V18 Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergiySW SergiySW SergiySW approved these changes

Assignees

@cryptocode cryptocode

Labels
unit test Related to a new, changed or fixed unit test
Projects
No open projects
V18
CP 3/RC 1 (2018-02-01)
Milestone
V18.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cryptocode @SergiySW