Remove vote generator delay #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemahieu
approved these changes
Apr 10, 2019
guilhermelawless
pushed a commit
to guilhermelawless/nano-node
that referenced
this pull request
Apr 15, 2019
* Remove voting delay * Remove generator delay constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colin realized we could remove the vote generator delay. Multiple hashes still got packed when I tested this on beta (with high tps it should still stuff 12 hashes into a v-b-h message)
Some confirmation height tests will fail intermittently until PR #1877 is merged.