Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confirmation_height.single test #1920

Merged

Conversation

2 participants
@wezrule
Copy link
Collaborator

commented Apr 25, 2019

I couldn't reproduce this locally, however I could see an obvious timing issue with the test. It only checks that one of the node ledgers has changed rather than both. I have changed the test to be more in line with the other ones by waiting until the block is confirmed in the node before querying it.

@wezrule wezrule added the unit test label Apr 25, 2019

@wezrule wezrule added this to the V19.0 milestone Apr 25, 2019

@wezrule wezrule requested a review from cryptocode Apr 25, 2019

@wezrule wezrule self-assigned this Apr 25, 2019

@wezrule wezrule merged commit 9f3f922 into nanocurrency:master Apr 25, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:fix_confirmation_height_single_test branch Apr 25, 2019

@zhyatt zhyatt added this to CP3/RC 1 (2019-04-26) in V19 Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.