Remove unnecessary copies when using lmdb cursors #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argakiig
approved these changes
May 30, 2019
|
@wezrule i suppose the copy constructor can't be deleted? Will be a hard habbit to break. |
argakiig
pushed a commit
that referenced
this pull request
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cursors used when iterating tables in lmdb already contain the objects in question as a pair (key -> value). A lot of places wrap
first/secondto make it more readable, but inadvertently end up copying the objects. I've replaced them with references.Also found a few other places where a copy is made unnecessarily so have used references there as well.