Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Valgrind] Check if running under valgrind before doing death tests #2145

Merged
merged 1 commit into from Jul 12, 2019
Merged

[Valgrind] Check if running under valgrind before doing death tests #2145

merged 1 commit into from Jul 12, 2019

Conversation

wezrule
Copy link
Contributor

@wezrule wezrule commented Jul 11, 2019

Valgrind is noisy with tests which use ASSERT_DEATH_IF_SUPPORTED as it basically forks a new process which is killed. I think it's better we don't output this during valgrind runs.

@wezrule wezrule added the sanitizers Related to thread, address or undefined sanitizers label Jul 11, 2019
@wezrule wezrule added this to the V20.0 milestone Jul 11, 2019
@wezrule wezrule self-assigned this Jul 11, 2019
@wezrule wezrule merged commit 243fa1c into nanocurrency:master Jul 12, 2019
@wezrule wezrule deleted the valgrind_death_tests branch July 12, 2019 11:23
@wezrule wezrule added this to CP0 in V20 Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptocode cryptocode cryptocode approved these changes

Assignees

@wezrule wezrule

Labels
sanitizers Related to thread, address or undefined sanitizers
Projects
No open projects
V20
CP0
Milestone
V20.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wezrule @cryptocode